CFE-4694: String replace lists#6219
Open
victormlg wants to merge 2 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
force-pushed
the
string_replace_lists
branch
2 times, most recently
from
fee25f7 to
d5e236d
Compare
victormlg
force-pushed
the
string_replace_lists
branch
4 times, most recently
from
619dcd3 to
0c2db2e
Compare
olehermanse
reviewed
Jul 8, 2026
olehermanse
reviewed
Jul 8, 2026
olehermanse
approved these changes
Jul 8, 2026
victormlg
force-pushed
the
string_replace_lists
branch
5 times, most recently
from
b28a4eb to
26290ef
Compare
Member
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14162/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14162/ |
larsewi
reviewed
Jul 13, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Consider refactoring "string" and "list" paths into two separate static functions to make it more readable. Furthermore, I would avoid goto's unless it saves you a lot of code.
victormlg
force-pushed
the
string_replace_lists
branch
3 times, most recently
from
6ba9450 to
4da006c
Compare
victormlg
force-pushed
the
string_replace_lists
branch
from
4da006c to
5baefa2
Compare
Changelog: Title Ticket: CFE-4694 Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
string_replace_lists
branch
from
5baefa2 to
7ed126e
Compare
craigcomstock
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.